pulling apart multiprocessing queue internals to fix the leftover FDs issue #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2013 15:31
…closes FDs test more informative when errors are encountered
| if v(fd_stat.st_mode)] | ||
| return FDInfo( | ||
| modes=[k for k, v in readable_mode_strings.items() if v(fd_stat.st_mode)], | ||
| symlink=os.readlink("/proc/{0}/fd/{1}".format(os.getpid(), fd_number))) |
There was a problem hiding this comment.
This doesn't look portable (I know this won't work on OS X, for example).
There was a problem hiding this comment.
Fixed in latest version -- I re-added the older version which scans for FDs, currently from 3 to 30 (tested manually by changing "/proc" to "/proc2")
|
Ship it! |
gatoatigrado
added a commit
that referenced
this pull request
Dec 12, 2013
pulling apart multiprocessing queue internals to fix the leftover FDs issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the old closes-fds test run 30 times, by default, which seemed to consistently produce the flakiness we were seeing earlier. I then dug into multiprocessing.queue internals, and found the pipes it was using which weren't closed. I then manually closed them. See #14 for details.